Allow resizing the source image for a volume #1123
Conversation
|
I see that #1122 touches something related to this change. If both are merged, we probably need to update some stuff to reuse the same code paths for resizing images. |
I've put a restriction of only resizing when the desired size is larger than the original size. Even though libvirt allows shrinking (but only when VIR_STORAGE_VOL_RESIZE_SHRINK is specified), this is not an operation that is readily supported by most VM images.
|
ℹ️ ℹ️ ℹ️ ℹ️ ℹ️ ℹ️ This contribution is relevant to the legacy version of the provider, which is now in the v0.8 branch of this repository. Future development is based on a new provider, which is not compatible with this one, nor does share code. As the new provider solves many issues with the legacy, and to make development in my free time more enjoyable, I have decided to close all PRs for the legacy provider, and to ask to check if the contribution would apply to the new one. This also to encourage trying the new version. and check the documentation:
You are free to reopen the PR for v0.8, which is targetted now to the v0.8 branch. We may also start a discussion if we can assemble a team of maintainters for the legacy branch. My efforts will go into the new provider. I ask you to check the new provider and re-evaluate this contribution. 🙏 |
2 participants
I've put a restriction of only resizing when the desired size is larger than the original size. Even though libvirt allows shrinking (but only when
VIR_STORAGE_VOL_RESIZE_SHRINKis specified), this is not an operation that is readily supported by most VM images.